D2K - Subfaction FactionSuffix #14457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it won't crash if a human player uses them.
ltem
previously approved these changes
Dec 10, 2017
There was a problem hiding this comment.
I didn't find any issues while testing it (keeping the follow up PRs in mind). The implementation is similar to Red Alert (https://github.com/OpenRA/OpenRA/blob/bleed/mods/ra/metrics.yaml), which I used for comparison.
|
The announcer and unit audio doesn't work for the new factions. The smugglers starport and mercenary heavy factory build icons are also combat tanks? |
|
Audio and these building icons will be fixed in the follow up PR #14458 |
|
Ok, I see. In that case 👍. @MustaphaTR can you please drop the testcase commit now? |
MustaphaTR
force-pushed
the
d2k-subfaction-radar-images
branch
from
3bbedd3
to
c06ab59
Compare
|
Removed the TESTCASE. |
ltem
approved these changes
Dec 11, 2017
|
Changelog (as suggested on IRC.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR making a human player one of the subfactions crashes the game on start.
I made it so using
FactionSuffix-those sides use the same UI with the side they share building artwork.Note that currently on OpenRA, Fremen are using Harkonnen structure artwork, this is wrong and i'll fix it with another PR.
Testcase enables the subfactions so you can test.